London | Jan-26 | Maryannne Mosonik | Sprint 1 | Wireframe to Web Code#1014
Open
Maryanne-K wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
London | Jan-26 | Maryannne Mosonik | Sprint 1 | Wireframe to Web Code#1014Maryanne-K wants to merge 6 commits intoCodeYourFuture:mainfrom
Maryanne-K wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Maryanne-K
added
the
Needs Review
codeschris
added
Review in progress
codeschris
suggested changes
Jan 23, 2026
Wireframe/index.html
Outdated
| Changes have been made here. | ||
| </p> | ||
| </footer> | ||
| <header> |
There was a problem hiding this comment.
The header is never below the footer. Check on this
Author
There was a problem hiding this comment.
@codeschris Kindly check, I have deleted the header and footer.
Wireframe/index.html
Outdated
| Changes have been made here. | ||
| </p> | ||
| </footer> | ||
| <header> |
There was a problem hiding this comment.
The header should be one across the entire page. Check on this and make changes
codeschris
suggested changes
Jan 24, 2026
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </header> | ||
| <main> |
There was a problem hiding this comment.
Consider having a single main tag and all articles inside that one main tag than repeating the main tag. Otherwise, everything else looks well
codeschris
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
I have committed several changes and create a webpage with three articles that has an accessibility score of 100%.
Is Lighthouse only a Google Chrome feature?
I agree to follow the code of conduct for this organisation.