London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Form-Controls #1027
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DamianDL
added
Needs Review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please can I have some help.
|
…ith Origional/main
…Origional/main-second attempt
DamianDL
added
Needs Review
|
Updated with changes to meet requirements;
HTML
|
cjyuan
added
Review in progress
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
| <style> | ||
| label { | ||
| font-size: 24px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
Normal practice is to keep embedded CSS in the <head> section.
| <div> | ||
| <!-- Name: at least 2 characters --> | ||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" name="name" required pattern=".{2,}" title="Name must be at least 2 characters long"> |
There was a problem hiding this comment.
Currently a user can enter a name consisting of only space characters (e.g., " "). Can you enforce a stricter pattern to disallow any name that contains only space characters?
Note: To enforce minimum number of characters in the input, it is better to use the minlength attribute.
| <div> | ||
| <!-- Email: basic format text@text.text --> | ||
| <label for="email">Email:</label> | ||
| <input type="email" id="email" name="email" required pattern="^[^@\s]+@[^@\s]+\.[^@\s]+$" title="Enter a valid email like user@example.com"> |
There was a problem hiding this comment.
Why use pattern in <input type="email"> when browsers can already perform built-in email validation?
| <option value="XXL">XXL</option> | ||
| </select> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
The indentation of some of the code is off. Can you improve the indentation?
VSCode's "Format Document" feature can help us format our code for better readability and consistency.
To use the feature, right-click inside the code editor and select the option.
cjyuan
added
Reviewed
|
In the Changelist section of the PR description, I am not sure what you mean by "How to save attributes". Can you update it accordingly to give a brief but clearer description of what you have changed in this PR branch? |
2 participants
Learners, PR Template
Self checklist
Changelist
How to save attributes
Questions
No outstanding questions yet