Skip to content

London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Form-Controls #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DamianDL wants to merge 17 commits into
base: main
Choose a base branch
from
+56 −8
Open

London | 26-ITP-Jan | Damian Dunkley | Sprint 2 | Form-Controls #1027

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a0943dd
Update text to answer three questions in 3 articles, with links.
DamianDL Jan 15, 2026
3e10354
Changes to page formatting into Wireframe template
DamianDL Jan 15, 2026
73b1697
Update to Forms for Sprint 2 exercise
DamianDL Jan 23, 2026
43967f2
centre header text
DamianDL Jan 23, 2026
f7fb669
refactor: cleaning up code
DamianDL Jan 23, 2026
173fecb
comments added and customer name input added
DamianDL Jan 23, 2026
31bebe9
putting back code deleted by mistake
DamianDL Jan 23, 2026
cf2b1ba
Revert "Update text to answer three questions in 3 articles, with lin…
DamianDL Jan 26, 2026
97c68bc
form bilt for name, email, colour and size
DamianDL Jan 26, 2026
8d5c720
replacing the Wireframe Index and CSS files in Form_Controls branch …
DamianDL Jan 27, 2026
ec9f9c4
replacing the Wireframe Index.html file in Form_Controls branch with…
DamianDL Jan 27, 2026
484e648
Font size updated to achieve lighthouse score 100
DamianDL Jan 29, 2026
d0bb4ed
Update Footer to my name and course
DamianDL Jan 29, 2026
175fc5e
Text formatting moved from body to head
DamianDL Jan 30, 2026
116596f
Changes as identified by validator tool
DamianDL Jan 30, 2026
24d7c27
Change to email input to require minimum of two charaters, neither ca…
DamianDL Jan 30, 2026
f8ded79
remove unnecessary validation of text for email type
DamianDL Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 56 additions & 8 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<style>
label {
font-size: 24px;
}
</style>
Copy link
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the indentation on lines 10, 41, 71-72?

You can use the VSCode's "Format Document" feature to auto-indent the code?
To use the feature, right-click inside the code editor and select the option.

<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="description" content="A form for selecting a product">
<meta name="viewport" content="width=device-width, initial-scale=1">
</head>
<body>
<header>
Expand All @@ -14,14 +19,57 @@ <h1>Product Pick</h1>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<!-- requirements,
customer name, must have at least two characters
Customers email must have format text@text.text
Colour choice, must be one of red, blue or green
Size choice must be Xs, S, M, L, XL, XXL
-->



<div>
<!-- Name: at least 2 characters -->
<label for="name">Name:</label>
<input type="text" minlength="2" id="name" name="name" required pattern=".*\S.*" title="Name must be at least 2 characters long, cannot be empty or just spaces">
</div>
<div>
<!-- Email: basic format text@text.text -->
<label for="email">Email:</label>
<input type="email" id="email" name="email" title="Enter a valid email like user@example.com">
</div>
<div>
<!-- Colour choice: red, blue, green -->
<label for="colour">Colour:</label>
<select id="colour" name="colour" required>
<option value="">Select a colour</option>
<option value="red">Red</option>
<option value="blue">Blue</option>
<option value="green">Green</option>
</select>
</div>
<div>
<!-- Size choice: XS, S, M, L, XL, XXL -->
<label for="size">Size:</label>
<select id="size" name="size" required>
<option value="">Select a size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>


<button type="submit">Submit</button>
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
<h2>
By Damian Dunkley for Code your Future ITP Jan 2026 Sprint 2</h2>
</footer>
</body>
</html>