-
-
Notifications
You must be signed in to change notification settings - Fork 401
Manchester | 26-ITP-Jan | Liban Jama | Sprint 2 | Form-Controls #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| <input id="Extra Extra Large"type="radio" name="size" value="XXL" /> | ||
| <label for="Extra Extra Large">Extra Extra Large</label> <br> | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we submit the form? is there an element to use to submit the form ?
| <br> | ||
|
|
||
| <p>Size</p> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done for the good work.
just a few more things to do
can we use a dropdown menu () for the sizes ?
when should you use radio buttons and drop down menu ()
see https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/select
| </p> | ||
| <p> | ||
| <label for="mail">Email</label> | ||
| <input type="email" id="mail" name="user_email" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use a placeholder to guide the users?
can we check for a minlength too ?
is there a way to validate the inputs?
can we use an attribute for the validation?
| </p> | ||
| <p>Colour</p> | ||
|
|
||
| <label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an attribute to associate the label with the radio button ?
| <form> | ||
| <p> | ||
| <label for="name">Name</label> | ||
| <input type="text" id="name" name="user_name" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use a minlength and other attribute to validate or make sure the input is required ?
can we use the placeholder to guide the users ?

Self checklist
Changelist
I created a form to collect customer data. The form consists of their name, email, t-shirt colour and size. I used only HTML. All the inputs have labels they are associated with. I scored 100 in the Lighthouse Accessibility score. Their name and email has to be a valid one and they can only pick one colour and size out of the options given.
Questions
N/A.