London | 26-ITP-January | Zadri Abdule | Sprint 1| Wireframe #815
Conversation
Fix links inconsistencies and remove ellipsis in HTML.
❌ Deploy Preview for cyf-onboarding-module failed. Why did it fail? →
|
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
Zadri415
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
2 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
Wireframe/index.html
Outdated
|
|
||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> |
There was a problem hiding this comment.
Currently all the images are placeholders - do you know what that means? Can you think of how this could be improved?
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| © 2025 Project Essentials. All rights reserved. |
There was a problem hiding this comment.
At times the footer text overlaps with the page content which is difficult to read - can you think of how to fix this while keeping the footer at the bottom of the viewport?
LonMcGregor
added
Reviewed
|
Thanks for making this change, this task is complete now |
LonMcGregor
added
Complete
Zadri415
changed the title
3 participants
Learners, PR Template
Self checklist
Changelist