Skip to content

Conversation

@lauracs24
Copy link

London | 26-ITP-January | Laura C | Sprint 1 | Wireframe to Web Code

#Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

#Changelist

I created a webpage based on the provided wireframe explaining README files, wireframes, and Git branches.
The page uses semantic HTML, is styled with CSS, and passes Lighthouse accessibility checks (hopefully).

@lauracs24 lauracs24 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 16, 2026
@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit b42debc
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974b3bcf9cacd0008630466
😎 Deploy Preview https://deploy-preview-963--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@JaypeeLan JaypeeLan added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 23, 2026
@JaypeeLan
Copy link

Good job on the short and straight-forward answers. By your definitions of git branch, it might be confusing for a beginner. This is a good reference: Git branch

@JaypeeLan JaypeeLan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 23, 2026
@lauracs24
Copy link
Author

Hi @JaypeeLan, sorry, should I rewrite the definition? I can see that the pull request is not 'complete' yet.

@JaypeeLan
Copy link

Yes you can read up the definition on W3 schools. It gives better insight and clear explanation. Then make a commit so I can update the label.

@lauracs24
Copy link
Author

Hi @JaypeeLan, I updated the definition to be clearer for beginners and added the W3Schools link. Thanks!

@lauracs24 lauracs24 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Jan 24, 2026
@takanocap takanocap assigned takanocap and unassigned takanocap Jan 29, 2026
@lauracs24
Copy link
Author

Hi @JaypeeLan let me know if you need anything else

@lauracs24
Copy link
Author

@cjyuan
@MorganDavid

Please let me know if either of you can review this request, as I would like to submit my module 1 onboarding soon. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants