West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Coursework Sprint 2 by Iswanna · Pull Request #778 · CodeYourFuture/Module-Structuring-and-Testing-Data

Iswanna · 2025-10-17T11:33:21Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this pull request, I completed the following:

Reviewed each file in the 1-key-errors directory, predicted the runtime errors, ran them with Node, and explained why each error occurred using the documentation.
Examined files in the 2-mandatory-debug directory, predicted why the programs were misbehaving, ran them to confirm, and corrected the code.
Implemented functions in the 3-mandatory-implement directory according to the provided requirements and tested them with multiple inputs to ensure correctness.
Analyzed larger programs in the 4-mandatory-interpret directory, researched unfamiliar syntax and functions, and used console.log to verify variable values and program flow.

Questions

Hi. Please could you review my PR? I’d really appreciate your feedback.

…uality operator

…S files accordingly

…rtions to compare current output with target output

…, and write the correct code.

…fy the issue, and add the corrected code.

- Predict the behavior of the existing code and provide explanations. - Include any error messages encountered during execution. - Provide the corrected code to fix the errors.

- Predict what will happen when the program runs. - Write the correct code to fix any errors.

…, and fix the code.

… produce the expected results.

…R_SNAKE_CASE

cjyuan

So far so good.

There are a few more files in 3-mandatory-implement and 4-mandatory-interpret.

The files in the prep folder is not quite related to the Sprint-2 exercise. To keep the branch clean, can you delete the folder from this branch?

Iswanna · 2025-10-26T18:20:57Z

So far so good.

There are a few more files in 3-mandatory-implement and 4-mandatory-interpret.

The files in the prep folder is not quite related to the Sprint-2 exercise. To keep the branch clean, can you delete the folder from this branch?

Hi @cjyuan.

Thank you for the helpful feedback and for spotting the missing updates in the 3-mandatory-implement and 4-mandatory-interpret files. I really appreciate the observation. I hadn’t pushed those changes earlier, but I’ve now pushed them to the remote repository.

I’ve also removed the prep folder from this branch as suggested to keep it clean. Thanks again for the review!

cjyuan · 2025-10-26T20:54:04Z

Sprint-2/3-mandatory-implement/3-to-pounds.js

+function toPounds(penceString) {
+const penceStringWithoutTrailingP = penceString.substring(
+  0,
+  penceString.length - 1
+);
+
+const paddedPenceNumberString = penceStringWithoutTrailingP.padStart(3, "0");
+const pounds = paddedPenceNumberString.substring(
+  0,
+  paddedPenceNumberString.length - 2
+);
+
+const pence = paddedPenceNumberString
+  .substring(paddedPenceNumberString.length - 2)
+  .padEnd(2, "0");
+
+  return `£${pounds}.${pence}`;
+
+// console.log(`£${pounds}.${pence}`);
+}


The code in the function is not properly indented.

This VSCode feature might interest you:
https://code.visualstudio.com/docs/languages/javascript#_formatting

The code in the function is not properly indented.

Hi @cjyuan.

Thank you for the feedback. I’ve fixed the inconsistent code indentation.

cjyuan · 2025-10-27T11:27:58Z

You did great. Thanks for making this PR easy to review.

Iswanna · 2025-10-27T11:35:54Z

You did great. Thanks for making this PR easy to review.

Hi @cjyuan.

Thank you! I’m glad the changes were clear. I really appreciate your feedback and review.

Iswanna added 20 commits October 4, 2025 01:43

Add some lines of code to calculate the area of a rectangle

60f2cf6

Add function to capitalize first letter of a name

909a41e

Compare the current output with the target output using the strict eq…

6b42d00

…uality operator

Organize prep directory into sprint-1 and sprint-2 folders and move J…

4470330

…S files accordingly

Use the console.assert function in the code

86552fe

Define a function to convert argument to time with "am" and add basse…

1f028f7

…rtions to compare current output with target output

Predict the output of the provided function, explain the actual error…

7993291

…, and write the correct code.

Explain why the program throws an error, simulate execution to identi…

aca4398

…fy the issue, and add the corrected code.

Add code predictions, explanations, and corrections

a8d716b

- Predict the behavior of the existing code and provide explanations. - Include any error messages encountered during execution. - Provide the corrected code to fix the errors.

Change the first letter in ActualOutput to lower case

b509c65

Predict program behavior and provide corrected code

f08d00a

- Predict what will happen when the program runs. - Write the correct code to fix any errors.

Improve phrasing in the prediction section for clarity

f4b2ba4

Predict what the sum function will output, explain how the code works…

09df5e9

…, and fix the code.

Comment out the lines of code with the error

b639581

Explain each line of the multiply function

f59d4fc

Predict and explain each function call’s output, then fix the code to…

ebaaadc

… produce the expected results.

Updatea function that takes two parameters to calculate the BMI

97e074f

Write a function that takes a string argument and converts it to UPPE…

49b8d14

…R_SNAKE_CASE

Refactor program into a reusable function

183ee2d

Add answers to questions about pad and formatTimeDisplay functions

2a3fc95

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module Module-Structuring-And-Testing-Data The name of the module. labels Oct 17, 2025

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 25, 2025

cjyuan reviewed Oct 25, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 25, 2025

Remove prep folder as it’s not related to this branch

a74b44e

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 26, 2025

cjyuan reviewed Oct 26, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025

Fix inconsistent code formatting

02aaf2a

Iswanna added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 27, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025

Iswanna mentioned this pull request Oct 30, 2025

West Midlands | Structuring and testing data | Iswat Bello Iswanna/My-Coursework-Planner#94

Open

illicitonion closed this Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Coursework Sprint 2#778

West Midlands | 25 Sep ITP | Iswat Bello | Sprint 2 | Coursework Sprint 2#778
Iswanna wants to merge 22 commits intoCodeYourFuture:mainfrom
Iswanna:coursework/sprint-2

Iswanna commented Oct 17, 2025

Uh oh!

cjyuan left a comment

Uh oh!

Iswanna commented Oct 26, 2025

Uh oh!

cjyuan Oct 26, 2025 •

edited

Loading

Uh oh!

Iswanna Oct 27, 2025

Uh oh!

cjyuan commented Oct 27, 2025

Uh oh!

Iswanna commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Iswanna commented Oct 17, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Iswanna commented Oct 26, 2025

Uh oh!

cjyuan Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Iswanna Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 27, 2025

Uh oh!

Iswanna commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cjyuan Oct 26, 2025 •

edited

Loading