This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Leidas week 8 homework #1005
Open
Leidas week 8 homework #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| .catch((error) => { | ||
| console.error(error); | ||
| }); |
| console.log("error!!!"); | ||
| console.error(error); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Good Job Leida, you forgot to implement error handling code at the fetched data. Implement that.
| console.error(error); | ||
| }); | ||
| } | ||
| getJoke(); |
There was a problem hiding this comment.
This function is correct, calling the function at line 20 is not appropriate. what you could do separate the fetching and the getJoke then call getJoke in the .then() or the easiest way apply the innerText in the .then() . Work on that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name: Leida Goncalves
Your City: Manchester
Your Slack Name: Leida Gandy
Homework Details
Module: JS Week III week 8
Week: 8