This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Azad week 3 #1019
Open
Azad week 3 #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoltan-gal
suggested changes
Jul 21, 2020
|
|
||
| function safeLevels() { | ||
|
|
||
| if (oxygenLevels1 >= "19.5%" && oxygenLevels1 <= "23.5%") { |
There was a problem hiding this comment.
oxygenLevels1 should have been an input parameter instead of using the global variable from outside.
There was a problem hiding this comment.
oxygenLevels1 >= "19.5%" comparison won't work because oxygenLevels1 is an array whereas "19.5%" is a string. Also, you have to parse number form the value of each array element and then compare as a number.
| /* + + + + + + + + + + + + + + */ | ||
|
|
||
| /* Now try to complete the exercise */ | ||
| function bushChecker(safeBush) { |
There was a problem hiding this comment.
Here you recognised here that you need input, but you haven't used it
|
|
||
| /* Now try to complete the exercise */ | ||
| function bushChecker(safeBush) { | ||
| if (bushBerryColours1 === "pink") { |
There was a problem hiding this comment.
Again, it is a comparison of an array and a string so it doesn't make sense logically.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name:
Your City:
Your Slack Name:
Homework Details
Module:
Week: