This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Nawal week 9 #1024
Open
Nawal week 9 #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashaghel
reviewed
Jul 10, 2020
| console.log(f1()) | ||
| console.log(y) | ||
| console.log(f1()) //undefined - no parameter inside. |
There was a problem hiding this comment.
Good work, the issue is there is no return
| console.log(y); | ||
| ``` | ||
| console.log(y); // x : 10 y is an object and returning its value pair | ||
| // ``` |
There was a problem hiding this comment.
Good answer, double check passing by value vs by reference
| // Use console.log() to output everything contained in your cart | ||
| console.log(this.currentTotal); | ||
|
|
||
| return this.currentTotal; |
| myCart.addItem("Toilet Roll"); | ||
| myCart.addItem("Pasta"); | ||
| myCart.addItem("Eggs"); | ||
| console.log(myCart.cartContains()); |
There was a problem hiding this comment.
you don't need to console log the method, it has console log inside, you just need to call it
| } | ||
|
|
||
| greeting() { | ||
| console.log('Hi! I\'m ' + this.personName + '.'); |
| return this.accountBalance | ||
| } | ||
| make_withdrawl(withdraw) { | ||
| this.withdraw = withdraw; |
There was a problem hiding this comment.
there is a small issue here, the idea is to have a balance and remove from it and add to it, no need to each return !
| } | ||
| } | ||
| // shuffle () { | ||
| // let randomSong = playList.length, temporaryValue, this.counterIndex; |
| // console.log("there is no songs to play"); | ||
| this.counterIndex = this.playList.length-1; | ||
| } | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name: Nawal
Your City: North West
Your Slack Name: nawalC
Homework Details
Module: js3
Week: 3