Skip to content

Fix #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeMirzayanov merged 1 commit into from
Aug 6, 2025
Merged

Fix #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions code/src/main/java/com/codeforces/commons/compress/ZipUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ public static void unzip(File zipArchive, File destinationDirectory, @Nullable F
}

File file = new File(destinationDirectory, fileHeader.getFileName()).getCanonicalFile();
if (!file.toPath().normalize().startsWith(destinationDirectory.toPath().normalize())) {
if (!file.getAbsolutePath().startsWith(destinationDirectory.getCanonicalPath())) {
throw new IOException("ZIP entry tries to escape destination directory: " + fileHeader.getFileName());
}

Expand All @@ -392,12 +392,8 @@ public static void unzip(File zipArchive, File destinationDirectory, @Nullable F

if (maxSize <= MAX_ZIP_ENTRY_SIZE) {
File parentDir = file.getParentFile();

try {
Files.createDirectories(parentDir.toPath());
} catch (Exception e) {
throw new IOException("Failed to create parent directory: '"
+ parentDir.getAbsolutePath() + "'.", e);
if (!parentDir.exists() && !parentDir.mkdirs()) {
throw new IOException("Failed to create parent directory: " + parentDir.getAbsolutePath());
}

Files.deleteIfExists(file.toPath());
Expand Down
Loading