Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

Conversation

@mcriscolo-cs
Copy link
Contributor

@mcriscolo-cs mcriscolo-cs commented Jul 26, 2023

External Spark connectors were removed from the profiles-sdk dependency tree due to having to shade everything not in base Spark. The connectors for AWS/GCS/ABS are still included in the docker image produced for the profiles-sdk. To ensure these connectors are present for running the examples outside a docker container, like when running main-app:run, including them on the runtime only classpath.

@mcriscolo-cs mcriscolo-cs requested a review from laguirre-cs July 27, 2023 19:51
laguirre-cs
laguirre-cs previously approved these changes Jul 27, 2023
Copy link
Collaborator

@laguirre-cs laguirre-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@laguirre-cs laguirre-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants