Closed
Conversation
The mutex implementation had a data race between unlock() reading head->next_ and await_suspend() writing to the mutex state when multiple coroutines race. Fixed by: - Changing await_suspend() CAS to use memory_order_acq_rel (was memory_order_release) - Changing unlock() initial load to memory_order_acquire (was memory_order_relaxed) This ensures proper synchronization between the unlock and await_suspend paths. Verified: All sync tests pass with ASAN and TSAN (198 assertions in 23 test cases)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.