fix: nodes2.0's combo widget does not respect "scale menus" setting #7491
Conversation
dosubot
bot
added
the
size:M
📝 WalkthroughWalkthroughThis PR introduces dynamic overlay positioning for dropdown components. The useTransformCompatOverlayProps composable now determines the appendTo value based on context menu scaling settings. The FormDropdown component adds an appendTo prop that controls whether the overlay renders within itself or in the document body. Changes
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 12/15/2025, 02:44:50 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
🎭 Playwright Test Results⏰ Completed at: 12/15/2025, 03:02:26 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.25 MB (baseline 3.25 MB) • ⚪ 0 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 986 kB (baseline 986 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 186 kB (baseline 184 kB) • 🔴 +2.28 kBReusable component library chunks
Status: 7 added / 7 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 3.18 kB (baseline 3.18 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.82 MB (baseline 3.82 MB) • ⚪ 0 BBundles that do not match a named category
Status: 19 added / 19 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
src/composables/useTransformCompatOverlayProps.ts(3 hunks)src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue(6 hunks)
🧰 Additional context used
📓 Path-based instructions (12)
src/**/*.{vue,ts}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.{vue,ts}: Leverage VueUse functions for performance-enhancing styles
Implement proper error handling
Use vue-i18n in composition API for any string literals. Place new translation entries in src/locales/en/main.json
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
src/**/*.ts
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.ts: Use es-toolkit for utility functions
Use TypeScript for type safetyMinimize the surface area (exported values) of each module and composable
Files:
src/composables/useTransformCompatOverlayProps.ts
src/**/{services,composables}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/{services,composables}/**/*.{ts,tsx}: Useapi.apiURL()for backend endpoints instead of constructing URLs directly
Useapi.fileURL()for static file access instead of constructing URLs directly
Files:
src/composables/useTransformCompatOverlayProps.ts
src/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
src/**/*.{ts,tsx,vue}: Sanitize HTML with DOMPurify to prevent XSS attacks
Avoid using @ts-expect-error; use proper TypeScript types instead
Use es-toolkit for utility functions instead of other utility libraries
Implement proper TypeScript types throughout the codebase
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
src/**/{composables,components}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Clean up subscriptions in state management to prevent memory leaks
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
src/**/*.{vue,ts,tsx}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Follow Vue 3 composition API style guide
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
src/**/{components,composables}/**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (src/CLAUDE.md)
Use vue-i18n for ALL user-facing strings by adding them to
src/locales/en/main.json
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
src/composables/**/*.ts
📄 CodeRabbit inference engine (AGENTS.md)
Composable files must follow the naming pattern
useXyz.ts
Files:
src/composables/useTransformCompatOverlayProps.ts
**/*.{ts,tsx,js,jsx,vue,json}
📄 CodeRabbit inference engine (AGENTS.md)
Code style: Use 2-space indentation, single quotes, no trailing semicolons, and 80-character line width (see
.prettierrc)
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
**/*.{ts,tsx,vue}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,vue}: Imports must be sorted and grouped by plugin; runpnpm formatbefore committing
Use TypeScript for type safety; never useanytype - use proper TypeScript types
Never useas anytype assertions; fix the underlying type issue instead
Use es-toolkit for utility functions
Write code that is expressive and self-documenting; avoid comments unless absolutely necessary; do not add or retain redundant comments
Keep functions short and functional
Minimize nesting in code (e.g., deeply nestediforforstatements); apply the Arrow Anti-Pattern principle
Avoid mutable state; prefer immutability and assignment at point of declaration
Favor pure functions, especially testable ones
Files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
src/**/*.vue
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
src/**/*.vue: Use the Vue 3 Composition API instead of the Options API when writing Vue components (exception: when overriding or extending PrimeVue components for compatibility)
Use setup() function for component logic
Utilize ref and reactive for reactive state
Implement computed properties with computed()
Use watch and watchEffect for side effects
Implement lifecycle hooks with onMounted, onUpdated, etc.
Utilize provide/inject for dependency injection
Use vue 3.5 style of default prop declaration
Use Tailwind CSS for styling
Implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Follow Vue 3 style guide and naming conventions
Files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
**/*.vue
📄 CodeRabbit inference engine (AGENTS.md)
**/*.vue: Use Vue 3 SFCs (Single File Components) with Composition API only; do not use Options API
Vue components must use<script setup lang="ts">for component logic
Use Vue 3.5 TypeScript style for default prop declaration with reactive props destructuring; do not usewithDefaultsor runtime props declaration
PreferuseModelto separately defining a prop and emit
Use Tailwind 4 utility classes for styling; avoid using<style>blocks in Vue components
Use semantic Tailwind values fromstyle.csstheme instead of thedark:variant; for example, usebg-node-component-surfaceinstead ofdark:prefixes
Always usecn()utility from@/utils/tailwindUtilto merge Tailwind class names; do not use:class="[]"syntax
Usereffor reactive state in Vue Composition API components
Implement computed properties withcomputed()from Vue; avoid using arefwith awatchif acomputedwould work instead
UsewatchandwatchEffectfor side effects in Vue components
Implement lifecycle hooks usingonMounted,onUpdated, and other Vue lifecycle functions
Useprovide/injectfor dependency injection; do not use dependency injection if a Store or shared composable would be simpler
Do not import Vue macros unnecessarily; only use when needed
Be judicious with addition of new refs or other state: prefer props, avoid redundantcomputed, and prefercomputedoverwatch
Use VueUse functions for performance-enhancing styles
In Vue Components, implement proper props and emits definitions
Utilize Vue 3's Teleport component when needed
Use Suspense for async components
Implement proper error handling in Vue components
Follow Vue 3 style guide and naming conventions
Use vue-i18n in composition API for any string literals; place new translation entries insrc/locales/en/main.json
Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
🧠 Learnings (16)
📓 Common learnings
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue OverlayPanel component with Popover
Applied to files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-09T03:39:54.501Z
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.
Applied to files:
src/composables/useTransformCompatOverlayProps.ts
📚 Learning: 2025-12-13T11:03:11.264Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.
Applied to files:
src/composables/useTransformCompatOverlayProps.ts
📚 Learning: 2025-12-11T12:25:15.470Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.
Applied to files:
src/composables/useTransformCompatOverlayProps.tssrc/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Dropdown component with Select
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Vue components must use `<script setup lang="ts">` for component logic
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.{vue,ts,js} : Use existing VueUse composables (such as useElementHover) instead of manually managing event listeners
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-09T03:49:52.828Z
Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 6300
File: src/platform/updates/components/WhatsNewPopup.vue:5-13
Timestamp: 2025-12-09T03:49:52.828Z
Learning: In Vue files across the ComfyUI_frontend repo, when a button is needed, prefer the repo's common button components from src/components/button/ (IconButton.vue, TextButton.vue, IconTextButton.vue) over plain HTML <button> elements. These components wrap PrimeVue with the project’s design system styling. Use only the common button components for consistency and theming, and import them from src/components/button/ as needed.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.{vue,ts} : Leverage VueUse functions for performance-enhancing styles
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Use `ref` for reactive state in Vue Composition API components
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-09T20:22:23.620Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-09T20:22:23.620Z
Learning: Applies to **/*.vue : Avoid new usage of PrimeVue components; prefer shadcn/vue or Reka UI instead
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-11-24T19:47:02.860Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-24T19:47:02.860Z
Learning: Applies to src/**/*.vue : Utilize ref and reactive for reactive state
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-11-24T19:47:45.616Z
Learnt from: CR
Repo: Comfy-Org/ComfyUI_frontend PR: 0
File: src/components/CLAUDE.md:0-0
Timestamp: 2025-11-24T19:47:45.616Z
Learning: Applies to src/components/**/*.vue : Replace PrimeVue Chips component with AutoComplete with multiple enabled
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-09T21:40:12.361Z
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.
Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
📚 Learning: 2025-12-11T03:55:51.755Z
Learnt from: simula-r
Repo: Comfy-Org/ComfyUI_frontend PR: 7252
File: src/renderer/extensions/vueNodes/components/ImagePreview.vue:151-158
Timestamp: 2025-12-11T03:55:51.755Z
Learning: In Vue components under src/renderer/extensions/vueNodes (e.g., ImagePreview.vue and LGraphNode.vue), implement image gallery keyboard navigation so that it responds to the node's focus state rather than requiring focus inside the image preview wrapper. Achieve this by wiring keyEvent handling at the node focus level and injecting or propagating key events (arrow keys) to the gallery when the node is focused/selected. This improves accessibility and aligns navigation with node-level focus behavior.
Applied to files:
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test
- GitHub Check: setup
- GitHub Check: lint-and-format
- GitHub Check: collect
🔇 Additional comments (6)
src/composables/useTransformCompatOverlayProps.ts (2)
4-4: LGTM: Import added for settings access.The import is necessary for reading the menu scaling preference.
49-59: The implementation is correct. The setting key'LiteGraph.ContextMenu.Scaling'is properly defined in the schema as a boolean, and both consumers (WidgetSelectDropdown.vueandWidgetSelectDefault.vue) correctly handle the returnedComputedRefby accessing.valuein their computed properties before spreading the result.src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue (4)
2-3: LGTM: Necessary imports added.The imports support the new appendTo prop typing and click-outside functionality for self-rendering mode.
46-67: LGTM: Well-documented prop addition.The
appendToprop is properly typed and documented. The default value of'body'maintains backward compatibility.
147-156: LGTM: Click-outside handler correctly implemented.The handler appropriately:
- Only activates in self mode
- Excludes the trigger element
- Closes the dropdown when clicking outside
VueUse's
onClickOutsidehandles the ref lifecycle gracefully when the element conditionally renders.
162-179: LGTM: Toggle and close logic handles both rendering modes.The functions correctly:
- Check for popover existence before calling methods
- Maintain
isOpenstate for both modes- Include explanatory comments for the self-mode path
| <div | ||
| v-if="isOpen" | ||
| ref="dropdownContainerRef" | ||
| class="absolute z-1001 top-8 left-0" | ||
| > | ||
| <FormDropdownMenu | ||
| v-model:filter-selected="filterSelected" | ||
| v-model:layout-mode="layoutMode" | ||
| v-model:sort-selected="sortSelected" | ||
| v-model:search-query="searchQuery" | ||
| :filter-options="filterOptions" | ||
| :sort-options="sortOptions" | ||
| :disabled="disabled" | ||
| :is-querying="isQuerying" | ||
| :items="sortedItems" | ||
| :is-selected="internalIsSelected" | ||
| :max-selectable="maxSelectable" | ||
| @close="closeDropdown" | ||
| @item-click="handleSelection" | ||
| /> | ||
| </div> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== Step 1: Locate FormDropdownMenu component ==="
find . -name "FormDropdownMenu.vue" -o -name "FormDropdownMenu.ts" -o -name "FormDropdownMenu.tsx" 2>/dev/null
echo -e "\n=== Step 2: Check FormDropdownMenu for keyboard event handling ==="
if [ -f "src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue" ]; then
echo "File found, checking for keyboard handlers..."
rg -n "onKey|@key|keydown|keyup|keypress|Escape" src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue
fi
echo -e "\n=== Step 3: Search for z-index values in renderer directory ==="
rg -n "z-\d{3,4}" src/renderer/ --type vue --type ts --type tsx | head -30
echo -e "\n=== Step 4: Check for z-1001 specifically ==="
rg -n "z-1001" src/ --type vue --type ts --type tsx
echo -e "\n=== Step 5: Search for common z-index patterns ==="
rg -n "z-\d+" src/renderer/extensions/vueNodes/widgets/components/form/dropdown/ --type vue --type ts --type tsxRepository: Comfy-Org/ComfyUI_frontend
Length of output: 587
🏁 Script executed:
#!/bin/bash
echo "=== Step 1: Check FormDropdownMenu for keyboard handlers ==="
cat src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue | grep -n -i "key\|escape\|@key"
echo -e "\n=== Step 2: Search for z-1001 in entire codebase ==="
grep -r "z-1001" src/ 2>/dev/null || echo "No z-1001 found"
echo -e "\n=== Step 3: Search for other high z-index values ==="
grep -rn "z-[0-9]\{3,4\}" src/renderer/extensions/vueNodes/widgets/components/form/ 2>/dev/null | head -20
echo -e "\n=== Step 4: Check FormDropdown.vue for all z-index usage ==="
grep -n "z-" src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
echo -e "\n=== Step 5: View FormDropdownMenu content to check keyboard handling ==="
wc -l src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 838
🏁 Script executed:
#!/bin/bash
echo "=== Step 1: View FormDropdownMenu.vue to check for keyboard/escape handling ==="
cat -n src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vue | head -50
echo -e "\n=== Step 2: Check FormDropdown.vue Popover configuration ==="
grep -A 10 -B 5 "Popover" src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue | grep -i "close\|escape"
echo -e "\n=== Step 3: View the entire Popover section in FormDropdown.vue ==="
sed -n '259,291p' src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
echo -e "\n=== Step 4: Check if there's any explanation for z-1001 in comments ==="
grep -B 3 -A 1 "z-1001" src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
echo -e "\n=== Step 5: Check FormDropdownMenu setup/script section ==="
sed -n '1,30p' src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenu.vueRepository: Comfy-Org/ComfyUI_frontend
Length of output: 4214
Add keyboard navigation and verify z-index consistency in self-rendering dropdown mode.
The self-rendering dropdown (lines 237-257) lacks keyboard event handling that the Popover mode provides:
-
Missing ESC key handler: The Popover version explicitly uses
:close-on-escape="true", but the self-rendered dropdown has no keyboard handling. FormDropdownMenu only emitsitem-clickandcloseevents—add an onKeydown handler to the dropdown container or FormDropdownMenu to close on ESC. -
Unexplained z-index: The self-render mode uses
z-1001while the Popover mode usesz-50. This 20x difference lacks justification and should be either documented or corrected for consistency.
🤖 Prompt for AI Agents
In
src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdown.vue
around lines 237 to 257, the self-rendered dropdown lacks keyboard handling and
uses an inconsistent z-index; add a keydown listener on the dropdown container
(or forward a keydown handler into FormDropdownMenu) that listens for Escape and
calls the existing closeDropdown method to close the menu, and change the
container's z-index class to match the Popover mode (z-50) or replace the
hardcoded class with a named prop/constant and document the intended stacking
context so both modes use the same, justified z-index.
DrJKL
deleted the
rizumu/fix/nodes2.0's-combo-widget-does-not-respect-"scale-menus"-setting
branch
|
Move to #7601 |
Overview
Users report that text scaling in Nodes 2.0 does not respect the "scale menus" setting. This is affecting the visual consistency and user experience when users adjust their menu scaling preferences.
Issue Details
The "scale menus" setting is intended to control the scaling of menu elements within the interface. However, text scaling is not respecting this setting, meaning text does not adjust proportionally when users change their menu scaling preferences.
┆Issue is synchronized with this Notion page by Unito