Skip to content

Conversation

@comfy-pr-bot
Copy link
Member

@comfy-pr-bot comfy-pr-bot commented Dec 20, 2025

Backport of #7550 to cloud/1.35

Automatically created by backport workflow.

┆Issue is synchronized with this Notion page by Unito

With reactivity fixed, control widgets would apply twice. This is fixed
by using the litegraph implementation.

Also adds control widget support for combos

Followup to #7539.

Known Issue:
- Primitive node do not have litegraph callbacks properly setup. As a
result, they will display an updated value when modified by control
widgets. Fixing this will requires a larger, separate PR

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-7550-Fix-doubled-control-application-2cb6d73d365081739a2fc40fdfb3630e)
by [Unito](https://www.unito.io)
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 20, 2025
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Dec 20, 2025
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 20, 2025
@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🎭 Playwright Test Results

Some tests failed

⏰ Completed at: 12/20/2025, 09:13:12 PM UTC

📈 Summary

  • Total Tests: 504
  • Passed: 492 ✅
  • Failed: 1 ❌
  • Flaky: 2 ⚠️
  • Skipped: 9 ⏭️

📊 Test Reports by Browser

  • chromium: View Report • ✅ 482 / ❌ 1 / ⚠️ 1 / ⏭️ 9
  • chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • mobile-chrome: View Report • ✅ 7 / ❌ 0 / ⚠️ 1 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

🎨 Storybook Build Status

Build completed successfully!

⏰ Completed at: 12/20/2025, 09:05:07 PM UTC

🔗 Links


🎉 Your Storybook is ready for review!

@christian-byrne christian-byrne merged commit e6475c3 into cloud/1.35 Dec 20, 2025
37 of 38 checks passed
@christian-byrne christian-byrne deleted the backport-7550-to-cloud-1.35 branch December 20, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants