Update to Minecraft version 1.21.11 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the CommunityRadar Fabric mod from Minecraft version 1.21.10 to 1.21.11, migrating from Yarn mappings to official Mojang mappings. This involves significant refactoring of class and package names throughout the codebase to align with Mojang's naming conventions.
Key changes:
- Migration from Yarn to Mojang mappings (e.g.,
Text→Component,MinecraftClient→Minecraft,PlayerListEntry→PlayerInfo) - Updated dependency versions (Fabric Loader 0.17.2 → 0.18.1, Fabric API, Fabric Loom)
- Renamed mixin classes to match new Minecraft class names (e.g.,
ChatHudMixin→ChatComponentMixin,PlayerEntityRendererMixin→AvatarRendererMixin) - Improved naming consistency (
MODID→MOD_ID,getModid()→getModId())
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated Minecraft to 1.21.11, Fabric Loader to 0.18.1, Fabric API to 0.139.4, Fabric Loom to 1.14-SNAPSHOT, removed Yarn mappings |
| gradle.properties | Updated mod version to 1.0.0-SNAPSHOT+1.21.11 |
| build.gradle.kts | Changed from Yarn mappings to official Mojang mappings |
| src/main/resources/communityradar.mixins.json | Renamed mixin classes to match Mojang naming (ChatHud→ChatComponent, PlayerEntityRenderer→AvatarRenderer, etc.) |
| src/main/java/io/github/communityradargg/fabric/utils/Utils.java | Migrated to Mojang API classes, updated method calls to match new API signatures |
| src/main/java/io/github/communityradargg/fabric/utils/RadarMessage.java | Changed Text API to Component API, renamed toText() to toComponent() |
| src/main/java/io/github/communityradargg/fabric/mixin/PlayerTabOverlayMixin.java | Renamed from PlayerListHudMixin, updated to use Mojang class names and method signatures |
| src/main/java/io/github/communityradargg/fabric/mixin/ChatComponentMixin.java | Renamed from ChatHudMixin, updated to use Component API and new method signatures |
| src/main/java/io/github/communityradargg/fabric/mixin/PlayerEntityRendererMixin.java | Deleted - replaced by AvatarRendererMixin to match Mojang naming |
| src/main/java/io/github/communityradargg/fabric/mixin/AvatarRendererMixin.java | New file replacing PlayerEntityRendererMixin with updated Mojang API usage |
| src/main/java/io/github/communityradargg/fabric/mixin/AvatarRenderStateMixin.java | Renamed from PlayerEntityRenderStateMixin to match Mojang naming |
| src/main/java/io/github/communityradargg/fabric/commands/RadarCommand.java | Updated to use Mojang API classes, migrated permission system from integer levels to PermissionLevel enum |
| src/main/java/io/github/communityradargg/fabric/accessors/AvatarRenderStateAccessor.java | Renamed from PlayerEntityRenderStateAccessor to match Mojang naming |
| src/main/java/io/github/communityradargg/fabric/CommunityRadarMod.java | Improved naming consistency (MODID→MOD_ID, getModid()→getModId()) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @param oldNameTagText The old text that should be extended, if needed. | ||
| * @return The new text for the including the radar prefix. | ||
| * @param oldNameTagText The old component that should be extended, if needed. | ||
| * @return The new component for the including the radar prefix. |
There was a problem hiding this comment.
Grammar issue in the documentation: "The new component for the including the radar prefix" should be "The new component including the radar prefix" (remove "for the").
Suggested change
| * @return The new component for the including the radar prefix. | |
| * @return The new component including the radar prefix. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/main/java/io/github/communityradargg/fabric/mixin/ChatComponentMixin.java:54
- The null check for
plainTexthas been removed. In the old code, there was a checkif (plainText == null)before processing the chat message. WhileComponent.getString()typically doesn't return null in Minecraft, removing this safety check could potentially cause issues if the behavior changes. Consider adding a null check or empty string check:if (component.getString() == null || component.getString().isEmpty()).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.