Skip to content

Fix podman test compatibility: remove hardcoded network backend #14422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: master
Choose a base branch
from
+7 −3
Open

Fix podman test compatibility: remove hardcoded network backend #14422

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6bf415
Initial plan
Copilot Feb 18, 2026
63d5b68
Remove unsupported mtu option from slirp4netns network configuration
Copilot Feb 18, 2026
c6620fd
Fix podman port extraction and remove explicit network mode
Copilot Feb 18, 2026
cb816c4
Address code review feedback
Copilot Feb 18, 2026
a01fdee
Remove trailing whitespace in tests/ssg_test_suite/test_env.py
Mab879 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/ssg_test_suite/test_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,13 @@ def get_ssh_port(self):
if self.domain_ip == 'localhost':
try:
ports = self._get_container_ports(self.current_container)
except Exception:
except Exception as exc:
msg = (
"Unable to extract SSH ports from the container. "
"This usually means that the container backend reported its configuration "
"in an unexpected format."
)
raise RuntimeError(msg) from None
raise RuntimeError(msg) from exc

if self.internal_ssh_port in ports:
ssh_port = ports[self.internal_ssh_port]
Expand Down Expand Up @@ -533,7 +533,6 @@ def _new_container_from_image(self, image_name, container_name):
"--cap-add=cap_sys_admin",
"--cap-add=cap_sys_chroot",
# "--privileged",
"--network", "slirp4netns:mtu=1500",
"--publish", "{}".format(self.internal_ssh_port), "--detach", image_name,
"/usr/sbin/sshd", "-p", "{}".format(self.internal_ssh_port), "-D"]
try:
Expand Down Expand Up @@ -573,11 +572,16 @@ def _get_container_ports(self, container):
return self.extract_port_map(json.loads(podman_output))

def extract_port_map(self, podman_network_data):
if not podman_network_data:
raise ValueError("Port data is empty or None")

if 'containerPort' in podman_network_data:
container_port = podman_network_data['containerPort']
host_port = podman_network_data['hostPort']
else:
container_port_with_protocol, host_data = podman_network_data.popitem()
if not host_data or not isinstance(host_data, list):
raise ValueError(f"Invalid port mapping data: {host_data}")
container_port = container_port_with_protocol.split("/")[0]
host_port = host_data[0]['HostPort']
port_map = {int(container_port): int(host_port)}
Expand Down