feat: fix opencode plugin and add gemini agent plugin#234
Open
taisung wants to merge 3 commits intoComposioHQ:mainfrom
Open
feat: fix opencode plugin and add gemini agent plugin#234taisung wants to merge 3 commits intoComposioHQ:mainfrom
taisung wants to merge 3 commits intoComposioHQ:mainfrom
Conversation
…plugin OpenCode plugin now has shell wrappers (gh/git interceptors), PATH prepend, setupWorkspaceHooks, and postLaunchSetup so PRs created by agents appear in the dashboard. Removed invalid --yes flag (opencode has no permissions bypass). New Gemini CLI plugin with full Agent interface: headless mode (-p), --yolo permissions, -m model, -r latest restore, session activity detection via ~/.gemini/tmp/ mtime, GEMINI.md system prompt, and shared shell wrappers. Both plugins registered in plugin-registry and CLI workspace deps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a57358c87
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Handle system prompt via compound shell command (cp/printf to GEMINI.md before launching gemini) since no --system-prompt CLI flag exists - Return null from getActivityState/getSessionInfo when process is running to avoid cross-session data leaks (no workspace-to-project-id mapping) - Guard getRestoreCommand with hasGeminiSessions() check, return null when no prior sessions exist so caller can fall back to getLaunchCommand - Remove unused findLatestGeminiSessionFile, stat import, mockStat Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
The systemPrompt parameter was never passed by either call site (setupWorkspaceHooks and postLaunchSetup). GEMINI.md writing is handled at launch time via getLaunchCommand's compound shell prefix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Can you please resolve all the comments? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh/gitinterceptors),setupWorkspaceHooks,postLaunchSetup, and PATH prepend to~/.ao/binso PRs created by agents appear in the dashboard. Removed invalid--yesflag (opencode has no permissions bypass CLI flag).@composio/ao-plugin-agent-geminiwith full Agent interface — headless mode (-p),--yolopermissions,-mmodel,-r latestrestore, session activity detection via~/.gemini/tmp/mtime,GEMINI.mdsystem prompt support, and shared shell wrappers.BUILTIN_PLUGINSand added as CLI workspace deps.Test plan
pnpm --filter @composio/ao-plugin-agent-opencode test)pnpm --filter @composio/ao-plugin-agent-gemini test)ao spawnwith opencode agent — verify no invalid flags, PR metadata updatesao spawnwith gemini agent — verify headless launch, session detection🤖 Generated with Claude Code