Skip to content

Comments

Resolve all TODOs in the codebase#133

Open
ketphan02 wants to merge 10 commits intomainfrom
resolve-TODO
Open

Resolve all TODOs in the codebase#133
ketphan02 wants to merge 10 commits intomainfrom
resolve-TODO

Conversation

@ketphan02
Copy link
Collaborator

@ketphan02 ketphan02 commented Apr 19, 2022

This accidentally merged #131

Resolve 2 issues:

  • config.jest.js is having an error saying there's no babel-jest
  • Loaded types are not import type -> make the source heavier
  • hash functions are not designed in a preferable way

Resolve TODOs:

  • Make sure DIFFICULT_LIST matches with the database's difficulties: RESOLVED ✅ by loading the type directly from the @prisma/client.
  • Create failed tests (and similars): UNRESOLVED ❌ because have no time and this is very time-consuming.
  • Age-related TODOs: UNRESOLVED ❌ because waiting for add-birth-year to be merged.
  • Create Header for admin page: RESOLVED ✅ by Admin header #121 (if got merged)
  • Convert bool to string: RESOLVED ✅ by using regex.

image

  • Calculate success rate of the submissions: RESOLVED ✅ with a new service and some implementation.
  • Save session to db (and local storage): UNRESOLVED ❌ because lack of time to implement.
  • Link to view on map: UNRESOLVED ❌ because lack of time to implement and no relative url in the view map.
  • Properly handle truncations (i.e. the ... at the end of sliced strings): UNRESOLVED ❌ because lack of time to implement.
  • Should be an alert dialog w/ link to login page: UNRESOLVED ❌ because lack of time to implement.

@ketphan02 ketphan02 requested review from Opeyem1a and yuqi88 April 19, 2022 12:25
@ketphan02 ketphan02 self-assigned this Apr 19, 2022
@ketphan02 ketphan02 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 19, 2022
@ketphan02 ketphan02 marked this pull request as ready for review May 4, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant