Skip to content

Conversation

@Mudaafi
Copy link
Contributor

@Mudaafi Mudaafi commented Nov 11, 2025

PR Description

  1. We add three new aggregation function options for variations_mapping
  • count
  • field_count
  • value_count
  1. We also expose the variation_slice field if it is a sliced result set.

Testing Enhancements

Since variation_slicing is a searchandizing rule, we can probably set up a test category/term for a full integration test

@Mudaafi Mudaafi requested review from a team and Copilot November 11, 2025 01:02
@Mudaafi Mudaafi requested a review from esezen as a code owner November 11, 2025 01:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for new variation aggregation functions and exposes the variation_slice field in search and browse results. The changes enable more flexible variation grouping and mapping capabilities.

Key Changes:

  • Added three new aggregation function types (count, field_count, value_count) to the VariationsMap.AggregationTypes enum
  • Exposed the variation_slice field in the Result model to capture sliced result set information
  • Added comprehensive test coverage for the new aggregation types and variation slice functionality

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
VariationsMap.java Added three new aggregation type enum values for variation mapping
Result.java Added variationSlice field with getter/setter methods to expose variation slice data
VariationsMapTest.java New test file validating serialization of all aggregation types including the three new ones
SearchResponseTest.java Added tests for variation slice presence/absence in search results
BrowseResponseTest.java Added tests for variation slice presence/absence in browse results
response.search.variation_slice.json New test fixture with search results containing variation slice data
response.browse.variation_slice.json New test fixture with browse results containing variation slice data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mudaafi Mudaafi merged commit 22c3a16 into master Nov 19, 2025
4 of 5 checks passed
@Mudaafi Mudaafi deleted the cdx-319-java-update-fields branch November 19, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants