Handle text API responses #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mudaafi
approved these changes
Apr 16, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
lgtm, just one comment.
Note: the
trackConversiontest for custom_type is currently failing due to Backend changing the error response.
Comment on lines
+8148
to
+8154
| fetchSpy = sinon.spy(() => Promise.resolve({ | ||
| ok: false, | ||
| status: 429, | ||
| statusText: 'Too Many Requests', | ||
| headers: new Map([['content-type', 'text/plain']]), | ||
| text: () => Promise.resolve('Too many requests'), | ||
| })); |
src/modules/tracker.js
Outdated
Comment on lines
179
to
184
| }).catch((error) => { | ||
| instance.eventemitter.emit('error', { | ||
| url, | ||
| method, | ||
| message: `Error reading text: ${error.message}`, | ||
| }); |
Contributor
There was a problem hiding this comment.
Should we standardize the the error handling for these two paths?
Contributor
There was a problem hiding this comment.
oh I meant that we catch and emit the error for .json() and .text() very similarly. Possibly something we can extract into a handler function?
Contributor
Author
There was a problem hiding this comment.
I see. You're right. Let me do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Content-Typeheader before processing the responseThe screenshot shows an example of the API response for 429 response