[CI-4396] Add optional price attribute to ItemTracked type #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekAlQaddy
commented
May 5, 2025
| // Response | ||
| expect(responseParams).to.have.property('method').to.equal('POST'); | ||
| expect(responseParams).to.have.property('message').to.equal('conversion type must be one of add_to_wishlist, add_to_cart, like, message, make_offer, read. If you wish to use custom types, please set is_custom_type to true and specify a display_name.'); | ||
| expect(responseParams).to.have.property('message').to.equal('Invalid parameters'); |
Contributor
Author
There was a problem hiding this comment.
The API now returns Invalid parameters instead and the full descriptive message is inside errors[0].message. After discussing with Jimmy, we decided to just change the error message for now to keep it simple in the tests
Mudaafi
approved these changes
May 7, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
lgtm, thanks for fixing spellcheck as well
esezen
approved these changes
May 8, 2025
esezen
deleted the
ci-4396-update-types-to-include-price-in-itemtracked-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.