Check and clean nodes which were created by the server, but client is not aware of it#3
Open
ishveda wants to merge 7 commits intoContinuumLLC:masterfrom
Open
Check and clean nodes which were created by the server, but client is not aware of it#3ishveda wants to merge 7 commits intoContinuumLLC:masterfrom
ishveda wants to merge 7 commits intoContinuumLLC:masterfrom
Conversation
…ut client is no more aware of it
ydidukh
approved these changes
Apr 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the node potentially was created by the server, but then client returned an error (e.g. ErrConnectionClose because of networking glitch), the node remains bound to the restored session and prevents acquisition of newer locks, since according to zk recipes for locks, there is a watch created on that node within the following lock, which dead locks further lock acquisition.