Skip to content

Conversation

@alex-quin-gabriel
Copy link
Member

Unfortunately, reStructuredText is lacking some features of material for mkdocs, which results in worse formatting and clarity of this version compared to the original.

The addition of the 'sphinx.ext.autosummary', 'sphinx.ext.autodoc' extensions might break the build with the given package versions.
It builds for me with:

  • breathe-4.36.0
  • docutils-0.21.2
  • jinja2-3.1.6
  • sphinx-8.2.3
  • sphinx_rtd_theme-3.0.2

@Rockjack00
Copy link

Please add a requirements.txt file or update the readme to include the new dependencies.

@alex-quin-gabriel
Copy link
Member Author

I did not make these changes on purpose. I want on opinion from @fmrico on this first.


**is_output_modelet_concept** ``(``\ ```engine`` <#engine>`__\ ``>``\ ```phenomenon`` <phenomenon.rst>`__\ ``)``
---------------------------------------------------------------------------------------------------------------
**is_output_modelet_concept** ( `engine <#engine>`_ > `phenomenon <phenomenon.html>`_ )
Copy link

@Rockjack00 Rockjack00 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**is_output_modelet_concept** ( `engine <#engine>`_ > `phenomenon <phenomenon.html>`_ )
**is_output_modelet_concept** (( `engine <#engine>`_ * `phenomenon <phenomenon.html>`_ )) > **$o** )


**template_has_concept_requirement** ``(``\ ```template`` <#template>`__\ ``>``\ ```concept`` <concept.rst>`__\ ``)``
--------------------------------------------------------------------------------------------------------------------
**template_has_concept_requirement** ( `template <#template>`_ > `concept <concept.html>`_ )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**template_has_concept_requirement** ( `template <#template>`_ > `concept <concept.html>`_ )
**template_has_concept_requirement** ( `template <#template>`_ > `concept <concept.html>`_ )
Suggested change
**template_has_concept_requirement** ( `template <#template>`_ > `concept <concept.html>`_ )
**template_has_concept_requirement** (( `template <#template>`_ * `concept <concept.html>`_ ) > **$o** )


**template_has_location_requirement** ``(``\ ```template`` <#template>`__\ ``>``\ ```spacetime_point`` <spacetime_point.rst>`__\ ``)``
-------------------------------------------------------------------------------------------------------------------------------------
**template_has_location_requirement** ( `template <#template>`_ > `spacetime_point <spacetime_point.html>`_ )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**template_has_location_requirement** ( `template <#template>`_ > `spacetime_point <spacetime_point.html>`_ )
**template_has_location_requirement** ( `template <#template>`_ > `spacetime_point <spacetime_point.html>`_ )
Suggested change
**template_has_location_requirement** ( `template <#template>`_ > `spacetime_point <spacetime_point.html>`_ )
**template_has_location_requirement** (( `template <#template>`_ * `spacetime_point <spacetime_point.html>`_ ) > **$o** )


**template_has_extent_requirement** ``(``\ ```template`` <#template>`__\ ``>``\ ```extent`` <extent.rst>`__\ ``)``
-----------------------------------------------------------------------------------------------------------------
**template_has_extent_requirement** ( `template <#template>`_ > `extent <extent.html>`_ )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**template_has_extent_requirement** ( `template <#template>`_ > `extent <extent.html>`_ )
**template_has_extent_requirement** (( `template <#template>`_ * `extent <extent.html>`_ ) > **$o** )

.. include:: datatype.rst
:start-line: 8
:end-line: 9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move concept to here to maintain alphabetical order.

Comment on lines 139 to 144
`concept <concept.html>`_
~~~~~~~~~~~~~~~~~~~~~~~~~

`template_set <template.rst#template_set>`__
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.. include:: concept.rst
:start-line: 8
:end-line: 9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 33 so these are in alphabetical order.

used by an `engine <engine.rst>`__. Class in the *Processing/Modelling
Model*. ###### Source: ``fundamental-concepts.tff``
The relation a `modelet <modelet.html>`_ has with its parents, i.e. the inputs to the `engine <engine.html>`_ `exertion <exertion.html>`_. Class of their relation in the *Processing/Modelling Model*.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did like the old description which talks about the extrinsic/intrinsic purpose

The purpose of a modelet (extrinsic to itself) when used by an engine. Class in the Processing/Modelling Model.


**is_property_of_modelet** ``((``\ ```property`` <#property>`__\ ``*``\ ```modelet`` <modelet.rst>`__\ ``) >``\ **``$o``**\ ``)``
--------------------------------------------------------------------------------------------------------------------------------
**is_property_of_modelet** (( `property <#property>`_ * `modelet <modelet.html>`_ ) > **$o** )
Copy link

@Rockjack00 Rockjack00 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**is_property_of_modelet** (( `property <#property>`_ * `modelet <modelet.html>`_ ) > **$o** )
**modelet_has_property** (( `modelet <modelet.html>`_ * `property <#property>`_ ) > **$o** )

I prefer the name as is_property_of_modelet because this is a predicate. However, right now it has the name modelet_has_property and I would rather stay consistent with the code base.


**is_property_of_engine** ``((``\ ```property`` <#property>`__\ ``*``\ ```engine`` <engine.rst>`__\ ``) >``\ **``$o``**\ ``)``
-----------------------------------------------------------------------------------------------------------------------------
**is_property_of_engine** (( `property <#property>`_ * `engine <engine.html>`_ ) > **$o** )
Copy link

@Rockjack00 Rockjack00 Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**is_property_of_engine** (( `property <#property>`_ * `engine <engine.html>`_ ) > **$o** )
**engine_has_property** (( `engine <engine.html>`_ * `property <#property>`_ ) > **$o** )

I prefer the name as is_property_of_engine because this is a predicate. However, right now it has the name engine_has_property and I would rather stay consistent with the code base.

- `Formalism <formalism.rst>`__: the representation of the *phenomenon*
###### Source: ``engines-and-modelets.tff``
Source: ``engines-and-modelets.tff``

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some information here about empty_ms, and parents_of_modelet since it looks like we are going the understanding state route.

Copy link

@Rockjack00 Rockjack00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added several notes today on the documentation while modeling the decision system. Apologies they all ended up in separate comments :o


.. _modelet_has_representation_class:

**modelet_has_representation_class** ( `modelet <modelet.html>`_ > `representation_class <representation_class.html>`_ )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**modelet_has_representation_class** ( `modelet <modelet.html>`_ > `representation_class <representation_class.html>`_ )
**modelet_has_representation_class** (( `modelet <modelet.html>`_ * `representation_class <representation_class.html>`_ ) > **$o** )

@fmrico
Copy link
Member

fmrico commented Oct 8, 2025

Is this PR abandoned?

@Rockjack00
Copy link

Probably, there have been some major changes since. @alex-quin-gabriel is the authority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants