fix: strip subagent wrapper continuation lines#495
Closed
Conversation
AliceLJY
commented
Apr 4, 2026
Collaborator
Author
AliceLJY
left a comment
There was a problem hiding this comment.
Self-review passed. Summary:
- Simplifies subagent wrapper stripping from complex single-pass lookbehind regex → two-pass line-by-line approach
- Header lines (
[Subagent Context/Task]) stripped entirely, continuation patterns caught independently - Simpler, more maintainable, easier to extend
1 file, +4/-4. mergeStateStatus: CLEAN.
@rwmjhb ready for your review.
Collaborator
Author
|
Closing — master already has a more robust implementation via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Subagent Context]/[Subagent Task]wrapper lines before memory extractionstrip-envelope-metadataregression expectations on currentmasterTesting
node --test test/strip-envelope-metadata.test.mjsThis is split out as a standalone baseline fix so unrelated PRs do not stay red because of the current subagent-wrapper regression on
master.