test: add client and blockchain test coverage#14
Merged
Conversation
Adds test_client.py (38 tests) covering the AlgoChat client class: - from_seed creation and key derivation - Conversation management (get/create, deduplication) - Encrypt/decrypt roundtrip (including unicode, empty messages) - Key discovery with caching behavior - Transaction processing (sent/received, conversation creation) - Sync from blockchain - Config factory methods Adds test_blockchain.py (24 tests) covering blockchain interfaces: - AlgorandConfig (localnet/testnet/mainnet, with_indexer) - Address decoding (_decode_algorand_address) - Key announcement parsing (verified/unverified signatures) - Key discovery (self-transfers, filtering, first-match) - Data model constructors Closes the two largest test coverage gaps in the codebase. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused imports (InMemoryMessageCache, AsyncMock, AlgodClient, etc.) - Remove unused variables (alice_pub, bob_pub, client) - Fix sign_encryption_key_bytes → sign_encryption_key (correct API) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Friendly review nudge — this PR has been open 6 days. Adds client and blockchain test coverage. Ready for review when you have a moment. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_client.py(38 tests) covering theAlgoChatclient class — the largest untested moduletest_blockchain.py(24 tests) covering blockchain interfaces, address decoding, key announcement parsing, and key discoveryAlgodClient/IndexerClientimplementations to test client behavior without network dependenciesCoverage gaps addressed
client.pyblockchain.pyTest plan
🤖 Generated with Claude Code