Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 63.61% 63.02% -0.59%
==========================================
Files 53 53
Lines 2105 2131 +26
==========================================
+ Hits 1339 1343 +4
- Misses 766 788 +22
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tutorial content to version 2 and refactors key plotting functions with new filtering, logging, and defaults.
- Refactor
rankplot.pyto support amin_presence_fractionfilter, group validation, dynamic colors, and logging. - Simplify
density.pyfigure/axis setup with aninternal_axflag and precise type hints. - Update documentation and notebooks: swap tutorial order, fix code fences, correct relative paths, reset execution counts.
- Add a new dependency
spatialdata-plotinpyproject.toml.
Reviewed Changes
Copilot reviewed 9 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/opendvp/plotting/volcano.py | Removed a stray comment. |
| src/opendvp/plotting/rankplot.py | Major refactor: min_presence filter, logging, default params. |
| src/opendvp/plotting/density.py | Streamline fig/ax logic, add Axes annotation. |
| pyproject.toml | Added new dependency spatialdata-plot. |
| docs/index.md | Fixed code fence formatting and list items. |
| docs/Tutorials/index.md | Swapped tutorial headings and updated links. |
| docs/Tutorials/…/*.ipynb | Updated notebook titles, relative paths, and cleared outputs. |
Comments suppressed due to low confidence (2)
src/opendvp/plotting/rankplot.py:44
- The order of parameters in the docstring does not match the function signature (min_presence_fraction appears after group_colors in the doc but before groups in the signature). Updating the doc order will reduce confusion.
min_presence_fraction : float, optional
src/opendvp/plotting/rankplot.py:55
- [nitpick] The default figure size was changed from (10, 6) to (5, 5), which may reduce plot readability. Consider restoring the previous size or making it configurable.
fig, ax = plt.subplots(figsize=(5, 5))
| "spatialdata==0.4.0", | ||
| "napari-spatialdata", | ||
| "pyqt5", | ||
| "spatialdata-plot", |
There was a problem hiding this comment.
This new dependency is added without a version pin. For reproducibility, consider specifying a version constraint for "spatialdata-plot."
Suggested change
| "spatialdata-plot", | |
| "spatialdata-plot>=1.0.0,<2.0.0", |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.