-
Notifications
You must be signed in to change notification settings - Fork 282
Update LogService class in CppMicroServices #1009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/LogService.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/LoggerFactory.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
compendium/LogService/include/cppmicroservices/logservice/LoggerFactory.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/Logger.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/LoggerFactory.hpp
Outdated
Show resolved
Hide resolved
compendium/LogService/include/cppmicroservices/logservice/LoggerFactory.hpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
@carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks. |
|
Sorry for the delay. Looks good.
- Mike.
…On Sep 5, 2024 at 8:45 AM -0400, Jeff DiClemente ***@***.***>, wrote:
@carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The current CppMicroServices LogService API and implementation that we ship with CppMicroServices does not confirm to the latest LogService OSGi spec (https://docs.osgi.org/specification/osgi.core/8.0.0/service.log.html).
Hence, to support latest features and classes, we are updating LogService class, which confirms to OSGi spec 8.
More information can be found out in the following RFC:
CppMicroServices/rfcs#21
Signed-off-by: The MathWorks, Inc.
architap@mathworks.com