Skip to content

Conversation

@architapruthi
Copy link
Contributor

The current CppMicroServices LogService API and implementation that we ship with CppMicroServices does not confirm to the latest LogService OSGi spec (https://docs.osgi.org/specification/osgi.core/8.0.0/service.log.html).

Hence, to support latest features and classes, we are updating LogService class, which confirms to OSGi spec 8.

More information can be found out in the following RFC:
CppMicroServices/rfcs#21

Signed-off-by: The MathWorks, Inc.
architap@mathworks.com

@architapruthi architapruthi self-assigned this May 28, 2024
@architapruthi architapruthi requested a review from kkumar45 May 28, 2024 07:22
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@architapruthi architapruthi marked this pull request as draft May 28, 2024 10:31
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 90.94203% with 25 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (9c87715) to head (d2ddd10).
Report is 2 commits behind head on development.

Files with missing lines Patch % Lines
compendium/LogServiceImpl/src/LogServiceImpl.cpp 78.78% 7 Missing ⚠️
compendium/LogServiceImpl/src/LoggerImpl.cpp 96.02% 7 Missing ⚠️
...ompendium/LogServiceImpl/src/LoggerFactoryImpl.cpp 50.00% 4 Missing ⚠️
compendium/ConfigurationAdmin/src/CMLogger.cpp 83.33% 2 Missing ⚠️
compendium/DeclarativeServices/src/SCRLogger.cpp 83.33% 2 Missing ⚠️
framework/src/util/CFRLogger.cpp 87.50% 2 Missing ⚠️
compendium/LogServiceImpl/src/LogServiceImpl.hpp 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1009      +/-   ##
===============================================
+ Coverage        88.29%   88.40%   +0.10%     
===============================================
  Files              248      252       +4     
  Lines            11931    12156     +225     
===============================================
+ Hits             10535    10746     +211     
- Misses            1396     1410      +14     
Files with missing lines Coverage Δ
...ompendium/LogServiceImpl/src/LoggerFactoryImpl.hpp 100.00% <100.00%> (ø)
compendium/LogServiceImpl/src/LoggerImpl.hpp 100.00% <100.00%> (ø)
framework/src/bundle/CoreBundleContext.cpp 95.09% <100.00%> (-0.05%) ⬇️
compendium/LogServiceImpl/src/LogServiceImpl.hpp 93.75% <93.33%> (-6.25%) ⬇️
compendium/ConfigurationAdmin/src/CMLogger.cpp 90.16% <83.33%> (-1.68%) ⬇️
compendium/DeclarativeServices/src/SCRLogger.cpp 93.44% <83.33%> (-2.48%) ⬇️
framework/src/util/CFRLogger.cpp 90.90% <87.50%> (+18.97%) ⬆️
...ompendium/LogServiceImpl/src/LoggerFactoryImpl.cpp 50.00% <50.00%> (ø)
compendium/LogServiceImpl/src/LogServiceImpl.cpp 78.57% <78.78%> (-21.43%) ⬇️
compendium/LogServiceImpl/src/LoggerImpl.cpp 96.02% <96.02%> (ø)

... and 1 file with indirect coverage changes

@jeffdiclemente jeffdiclemente marked this pull request as ready for review June 5, 2024 11:27
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@jeffdiclemente
Copy link
Member

@carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks.

@carneyweb
Copy link
Contributor

carneyweb commented Sep 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants