Fix vault size being zero when printed via schematic#10084
Open
Apertyotis wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix vault size being zero when printed via schematic#10084Apertyotis wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Apertyotis wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Conversation
VoidLeech
added
pr type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When printing a vault using a schematic, the Length and Size NBT values are ignored, resulting in a vault with zero capacity.
This issue does not manifest in multi-block vaults because structure updates recalculate the correct size. However, single-cell vaults are affected and remain at zero capacity.
A similar issue previously affected tanks and was resolved in commit 1491ed3. This PR applies a similar fix to vaults.