make item req more datadriver + use pickup data to place safenbt block#10107
Open
cylian914 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
Open
make item req more datadriver + use pickup data to place safenbt block#10107cylian914 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
cylian914 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
Conversation
VoidLeech
reviewed
Mar 30, 2026
src/main/java/com/simibubi/create/content/schematics/requirement/ItemRequirement.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/schematics/requirement/ItemRequirement.java
Outdated
Show resolved
Hide resolved
src/main/java/com/simibubi/create/content/schematics/requirement/ItemRequirement.java
Show resolved
Hide resolved
src/main/java/com/simibubi/create/infrastructure/data/CreateRegistrateTags.java
Outdated
Show resolved
Hide resolved
cylian914
added a commit
to cylian914/Domum-Ornamentum
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this add the strict_nbt_match tag that allow to use StrictNbtStackRequirement using data
and shematic_damage_type that allow to use the damage usageType using data
also uses blockState.getCloneItemStack to copy nbt for block that have the safe nbt tag (fix #10102, still need to put domum ornamentum block in safenbt)