feat: add isSmartWalletSignature parameter to signTypedData#1374
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
feat: add isSmartWalletSignature parameter to signTypedData#1374devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Add optional isSmartWalletSignature parameter to SignTypedDataInput interface - Update EVMWallet.signTypedData to use parameter instead of hardcoded false - Defaults to false for backward compatibility - Enables smart wallet signatures when set to true Fixes WAL-6377 Co-Authored-By: jorge@paella.dev <jorge@paella.dev>
Contributor
Author
Original prompt from jorge@paella.dev |
🦋 Changeset detectedLatest commit: 81ddb54 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-Authored-By: jorge@paella.dev <jorge@paella.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the
isSmartWalletSignatureparameter in the SDK'ssignTypedDatamethod to allow users to get smart wallet signatures instead of the default signer signatures. Previously, this parameter was hardcoded tofalse, but the backend API already supports it.Changes made:
isSmartWalletSignature?: booleanparameter toSignTypedDataInputinterfaceEVMWallet.signTypedDatamethod to use the parameter instead of hardcodingfalsefalsefor backward compatibilityContext: This addresses Linear ticket WAL-6377 where users needed to get ERC6492-wrapped smart wallet signatures for permit2 compatibility testing.
Link to Devin run: https://app.devin.ai/sessions/894691ae61ac40ddaf6cce140226d50b
Requested by: @jorge2393
Test plan
signTypedDatacalls continue to work unchanged (default behavior preserved)isSmartWalletSignature: truereturns smart wallet signatures (ERC6492-wrapped)Package updates
No package updates required - this is a feature addition using existing dependencies.
Human review checklist
🔍 Critical items to verify:
isSmartWalletSignatureparameter correctlysignTypedDatausagefalsewhen parameter omitted)