Conversation
Co-Authored-By: Fede Sarquis <fede@paella.dev>
🦋 Changeset detectedLatest commit: 46086ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Original prompt from Fede |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🔥 Smoke Test Results |
| : "cd53135a-b32b-4704-bfca-324b665e9329", | ||
| cssOverrides: `.powered-by-dynamic { display: none !important; }`, | ||
| suppressEndUserConsoleWarning: true, | ||
| ...settings, |
There was a problem hiding this comment.
small nit: dynamics docs doesn't mention the prop suppressEndUserConsoleWarning so my concern is it maybe partially works? maybe to safeguard and guarantee this change we should also add logLevel: "MUTE", in addition.
jmderby
left a comment
There was a problem hiding this comment.
small nit but approving anyways
Description
The Dynamic SDK (
@dynamic-labs/sdk-react-core), which is used internally by the Crossmint SDK for crypto wallet connections, outputs a self-XSS protection warning to the browser console prefixed with[DynamicSDK] [INFO]: Warning!. This is confusing for Crossmint SDK consumers since they don't interact with Dynamic directly.This sets
suppressEndUserConsoleWarning: truein theDynamicContextProviderWrappersettings to suppress it. The prop is placed before the...settingsspread, so consumers can still override it if needed.Link to Devin run | Requested by @fedemint
Human review checklist
suppressEndUserConsoleWarningbefore...settings(allowing consumer override) is the desired behavior vs. placing it after (always suppressing)Test plan
No automated tests needed — this is a single config flag passed to the Dynamic SDK's
DynamicContextProvider. Can be verified by opening the browser console in any app using the Crossmint embedded checkout or wallet provider and confirming the[DynamicSDK] [INFO]: Warning!message no longer appears.Package updates
@crossmint/client-sdk-react-ui: patch (changeset added)