chore: sync CrowdFlower/ruby-kafka with zendesk/ruby-kafka#13
Open
AndreyNenashev wants to merge 73 commits intomasterfrom
Open
chore: sync CrowdFlower/ruby-kafka with zendesk/ruby-kafka#13AndreyNenashev wants to merge 73 commits intomasterfrom
AndreyNenashev wants to merge 73 commits intomasterfrom
Conversation
fix Kafka::TransactionManager#send_offsets_to_txn
Add kafka 2.6.0 to Circle CI
In the example, one consumer sometimes consumers all messages before another consumer joins. As a result, the example is unstable. This commit makes it stable by ensuring all consumers have joined.
Resolve "Passing the keyword argument as ..." deprecation warning
…-error Resolve RSpec::Mocks::OutsideOfExampleError
Co-authored-by: Daniel Schierbeck <dasch@zendesk.com>
…ategy-example-stable Make "consuming messages with a custom assignment strategy" stable
kafka 2.7.0
And all the plumbing to load it
Make ssl_ca_cert_file_path support an array of files
This spec stopped working at some point
On `rescue Kafka::Error` we're rerunning the whole method block including `@logger.push_tags(@producer.to_s)`, but clearing tags only in `ensure` which is not run on `retry`
Fix multiple `[Producer name]` tags on failures
There wasn't support for authenticating with AWS's IAM, so here it is. Based off instructions @ https://github.com/aws/aws-msk-iam-auth Something along these lines to test/connect: ``` k = Kafka.new( seed_brokers: [array of seed brokers as defined by aws], client_id: 'client_id', logger: Rails.logger, partitioner: Kafka::Partitioner.new, sasl_aws_msk_iam_access_key_id: 'iam_access_key', sasl_aws_msk_iam_secret_key_id: 'iam_secret_key', sasl_aws_msk_iam_aws_region: 'us-west-2', ssl_ca_certs_from_system: true ) k.topics ``` IAM auth-enabled kafka instances should be on post 9098, so seed broker array such as `['host1.aws.com:9098', 'host2.aws.com:9098'] etc. More instructions on how to find these hostnames for your MSK setup @ https://github.com/aws/aws-msk-iam-auth
AWS MSK IAM auth
Update CI and Tests
The `topic` key is already being set in `tags`, so these method calls don't actually do anything.
Avoid unnecessary Hash merges
…hore/upgrade-from-zendesk
AndreyNenashev
changed the title
stasCF
approved these changes
Jul 11, 2022
maj
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.