Open
Conversation
fix Kafka::TransactionManager#send_offsets_to_txn
Add kafka 2.6.0 to Circle CI
In the example, one consumer sometimes consumers all messages before another consumer joins. As a result, the example is unstable. This commit makes it stable by ensuring all consumers have joined.
Resolve "Passing the keyword argument as ..." deprecation warning
…-error Resolve RSpec::Mocks::OutsideOfExampleError
Co-authored-by: Daniel Schierbeck <dasch@zendesk.com>
…ategy-example-stable Make "consuming messages with a custom assignment strategy" stable
kafka 2.7.0
And all the plumbing to load it
Add `murmur2_random` support for message partitioning.
Control batches can show up even outside of transactions. This change drops the requirement that you must be in a transaction for a record to be labled a control batch.
By default, the Java implementation of a Kafka client can use each returned IP address from a hostname. cf. https://kafka.apache.org/documentation/#client.dns.lookup librdkafka also does: > If host resolves to multiple addresses librdkafka will > round-robin the addresses for each connection attempt. cf. https://github.com/edenhill/librdkafka/blob/v1.5.3/INTRODUCTION.md#brokers Such a feature helps us to manage seed brokers' IP addresses easily, so this commit implements it.
This commit resolves the following warnings: ``` % yard doc [warn]: @param tag has unknown parameter name: group_id: in file `lib/kafka/cluster.rb' near line 122 [warn]: @param tag has unknown parameter name: transactional_id: in file `lib/kafka/cluster.rb' near line 132 [warn]: @param tag has unknown parameter name: string in file `lib/kafka/protocol/encoder.rb' near line 131 -- snip -- ```
…ultiple-addresses Support seed brokers' hostname with multiple addresses
Fix "@param tag has unknown parameter name"
Updated to ignore all control batches
When the error code is non-zero there isn't necessarily (ever?) an assignment. Currently the decoder raises a `TypeError` ("no implicit conversion of nil into String") - this updates the logic to only try to decode the assignment if there are any bytes.
…-sync-failure-responses Handle SyncGroup responses with a non-zero error and no assignments
|
@keithwoody do we still need to merge it? or better to open another sync? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with zendesk/ruby-kafka