This repository was archived by the owner on Sep 22, 2025. It is now read-only.
NA9ZHD - Költségnapló #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmaster442
left a comment
webmaster442
left a comment
There was a problem hiding this comment.
- Unit teszt projekt teszttel ✅
- Dependency inversion ✅
- Singleton ❌, de legalább tudod, hogy nem szép 🤘
- Ékezetes enum elemek ❌, Oké, hogy a nyelv lehetőséget ad rá, de Na 😀
- Pokémon exception handling JSON Beolvasáskor ? Nem a legjobb ötlet ❌
- Program.cs AddNewTranzaction - Bőven lehetett volna kisebb részekre vágni ❌
- A UI kód eléggé karbantarthatatlan 2 betűs függvény nevekkel. Ezt lehetett volna szépíteni. ❌
Így ebben a formában nem tudom rá megadni a legjobb jegyet. Vannak benne nem szép megoldások, de látszik, hogy időt töltöttél vele.
|
|
||
| public enum Months | ||
| { | ||
| JANUÁR = 1, |
Contributor
There was a problem hiding this comment.
Ékezetes enum elemek ❌, Oké, hogy a nyelv lehetőséget ad rá, de Na 😀
| MonthlyLedger ledger = new MonthlyLedger(year, month, transactions); | ||
| DataWarden.Instance.StoreMonth(ledger); | ||
| } | ||
| catch (Exception) { UIManager.PrintError(0, 1); continue; } |
Contributor
There was a problem hiding this comment.
Pokémon exception handling JSON Beolvasáskor ? Nem a legjobb ötlet
| } | ||
| public static void PrintProfit(int[] calculations, byte profitDifferenceColorCode) | ||
| { | ||
| CC(ConsoleColor.Green); |
Contributor
There was a problem hiding this comment.
Karakterek ingyen vannak, illetve vannak ANSI escape kódok is formázásra
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.