-
Notifications
You must be signed in to change notification settings - Fork 16
Benedek László - IH1RZJ #5
base: master
Are you sure you want to change the base?
Conversation
webmaster442
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- CI/CD ✅
- Singleton ❌
- Terminal.Gui ✅
- Van interfész szegregáció és dependency inversion ✅
- Async/Await ✅
Szép munka, látszik a kód mennyiségből és minőségből, hogy foglalkoztál vele.
| @@ -0,0 +1,26 @@ | |||
| name: Build project | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI/CD - Nájsz
| public static Config Instance | ||
| { | ||
| get | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jáájj :D Singleton
|
|
||
| using Microsoft.Extensions.Configuration; | ||
|
|
||
| using Terminal.Gui; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nájsz.
| @@ -0,0 +1,69 @@ | |||
| # Film értékelő alkalmazás | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dokumentáció, nájsz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DTO absztrakció. Ez is tetszik.
|
|
||
| public record class AppearanceJsonDTO | ||
| { | ||
| public Guid ID { get; init; } = Guid.NewGuid(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET 9 óta van V7-es GUID is. Guid.CreateV7() asszem a factory metódusa. Amíg JSON-ba vagy teljesen jó a V4-is, de amint ezt DB-be akarod tenni, már nem. Órán majd kérdezz rá, hogy miért inkább V7-es Guid, ha érdekel.
No description provided.