-
Notifications
You must be signed in to change notification settings - Fork 2
Make CueSync a web component #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored cuesync.js to define <cue-sync> as a web component - Added Shadow DOM encapsulation and custom attributes - Updated initialization to register CueSync with customElements API - Introduced `theme` attribute with support for light, dark, and auto modes - Added language selection dropdown for handling multiple transcript languages - Provided layout options (stacked, paragraph) to toggle transcript display style - Added settings menu to allow user interaction with customization options
Ensures that changes to attributes such as theme, layout, show-timestamp, and auto-scroll are immediately reflected in the UI without requiring a full refresh.
…eparation of concerns and maintainability.
…wanted html elements Recreate _handleTimeUpdate() everytime _addMediaEventListener() is called to avoid referencing to stale transcript lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<cue-sync>as a web componentthemeattribute with support for light, dark, and auto modesType of changes
Checklist
npm run lint)