Skip to content

fix(p2p-11): harden reader and listener lifecycle (#671)#752

Open
jlon wants to merge 21 commits intoCurvineIO:mainfrom
jlon:p2p-11-reader-listener-lifecycle-hardening
Open

fix(p2p-11): harden reader and listener lifecycle (#671)#752
jlon wants to merge 21 commits intoCurvineIO:mainfrom
jlon:p2p-11-reader-listener-lifecycle-hardening

Conversation

@jlon
Copy link
Copy Markdown
Contributor

@jlon jlon commented Mar 26, 2026

Summary

  • Harden reader failure handling and data-plane listener lifecycle.
  • Make this the first redirect slice that is reasonable for rollout when stacked on p2p-10.

Design

  • Keep worker fallback correct and prevent broken remote readers from re-entering the pool.
  • Isolate listener retry, shutdown, and generation safety from later performance work.

Implementation

  • Fix last-replica failure handling, remote reader cleanup, and block client pool hygiene.
  • Add listener retry/stop/start hardening and the FsContext and pool lifetime fixes needed for P2P lifecycle.

Verification

  • Verify broken remote readers are not returned to the pool.
  • Verify stop/start is clean and transient listener failures self-recover.

@jlon
Copy link
Copy Markdown
Contributor Author

jlon commented Mar 26, 2026

Part 11/17 of the split P2P series that supersedes #671.

This PR targets , so the visible diff is cumulative. Review the slice described in this PR body instead of treating the whole diff as new.

Intended review delta is p2p-11 on top of #753.

@jlon
Copy link
Copy Markdown
Contributor Author

jlon commented Mar 26, 2026

Review note: this is part 11/17 of the split P2P series that supersedes #671.

This PR targets main, so the visible diff is cumulative. Please review the slice described in this PR body.

Review after #753.

@jlon jlon force-pushed the p2p-11-reader-listener-lifecycle-hardening branch from bd6a1a3 to 3da3eea Compare March 26, 2026 10:26
@jlon jlon force-pushed the p2p-11-reader-listener-lifecycle-hardening branch from 3da3eea to a0d27ba Compare March 27, 2026 09:33
@jlon jlon force-pushed the p2p-11-reader-listener-lifecycle-hardening branch from a0d27ba to 50bb594 Compare March 30, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant