Always allow access if group_id is an empty string#61
Open
georgestagg wants to merge 1 commit intoCyberNinjas:masterfrom
Open
Always allow access if group_id is an empty string#61georgestagg wants to merge 1 commit intoCyberNinjas:masterfrom
georgestagg wants to merge 1 commit intoCyberNinjas:masterfrom
Conversation
Using an empty group string causes the user group check to be skipped
oxr463
approved these changes
Nov 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so that the group membership check is skipped if
group_idis empty.The reasoning is that if our azure app is not authorised to read group membership with
/checkMemberGroups, then this is a way to makepam_aadnot worry about it, rather than error. (And group based access can be enforced with other PAM modules, if required.)