fix: case-sensitive header lookup in HttpResponse getValue method#2
Open
jm-riley wants to merge 1 commit intoCyberSource:mainfrom
Open
fix: case-sensitive header lookup in HttpResponse getValue method#2jm-riley wants to merge 1 commit intoCyberSource:mainfrom
jm-riley wants to merge 1 commit intoCyberSource:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
getValuemethod in HttpResponse performs a case-sensitive lookup of header keys after lowercasing the input key. This causes issues when response headers like "Digest" need to be retrieved as part of verification.While creating the transient token, response from
/flex/v2/tokensrequest contains a response header ofDigest. CallingDigestHelper.verifyResponseDigest()will always throw amissingDigestHeadererror when attempting to assigndigestHeadervalue:This change modifies the
HttpResponse.getValue()function to: