fix users being able to bypass selecting background region#274
Open
MrMondrian wants to merge 1 commit intodevfrom
Open
fix users being able to bypass selecting background region#274MrMondrian wants to merge 1 commit intodevfrom
MrMondrian wants to merge 1 commit intodevfrom
Conversation
… removed instead of a tiny one replacing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address bug raised in this issue.
We thought the users could bypass selecting a background region before submitting to rodan. The actual issue that when users click on the screen, it looks as though the selection box is being deleting. This is not the case. Instead, a 1x1 selection box is created that is too small to see.
The mouse up logic has been changed to delete the select box if it has 0 area.