Fix: manifest-proxy URL trailing slash redirect#935
Draft
kyrieb-ekat wants to merge 4 commits intomainfrom
Draft
Fix: manifest-proxy URL trailing slash redirect#935kyrieb-ekat wants to merge 4 commits intomainfrom
kyrieb-ekat wants to merge 4 commits intomainfrom
Conversation
Removes trailing slash from manifest-proxy URL pattern to prevent 301 redirects that cause AJAX requests to hang when fetching IIIF manifests. Fixes #933
Contributor
Author
|
converted back to draft, to fix failed linter tests etc |
…side /cantus/app/public/cantusdata/, in anticipation of re submitting the PR resolving issue #933
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes trailing slash from manifest-proxy URL pattern to prevent 301 redirects that cause AJAX requests to hang when fetching IIIF manifests.
Fixes #933