Upgrade Diva.js from v5.0 to v6.0.2 for IIIF Presentation 3.0 support#936
Open
kyrieb-ekat wants to merge 11 commits intomainfrom
Open
Upgrade Diva.js from v5.0 to v6.0.2 for IIIF Presentation 3.0 support#936kyrieb-ekat wants to merge 11 commits intomainfrom
kyrieb-ekat wants to merge 11 commits intomainfrom
Conversation
…m npm (diva.js@6.0.2)- Old structure: js/, css/, demo/ → New structure: build/, source/- Pre-built files now in build/ directory instead of js/ and css/- Kept v5 backup in diva.js.v5.backup/ (not tracked)- Webpack config will need update to point to build/diva.jsRelated to #933 - needed for IIIF Presentation 3.0 support
…alias from js/diva.js → build/diva.js- gulpfile: Update CSS source from src/styles/diva.min.css → dependencies/diva.js/build/diva.cssPart of Diva v5 → v6.0.2 upgrade
…rom dependencies/diva.js/build/diva.css
….1 (51) to 6.01 (601)
…olpiano51_web.zip to volpiano601_web.zip- Removed subdirectory from extraction path (zip extracts directly)- Files are now at root level, not in volpiano601_web/ subdirectory
kyrieb-ekat
added
Public Website
Member
|
Thanks @kyrieb-ekat I’m surprised it didn’t need any changes to the cantus app itself. At least, I can’t see any… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #933 - Salzinnes manuscript (123723) not displaying due to IIIF Presentation API version mismatch.
Changes
build/instead ofjs/andcss/)Testing
Related
"can't access property 'length', e.pgs is undefined"errorThanks to @ahankinson for guidance on Diva versioning and IIIF Presentation API compatibility issues.
@ahankinson - tagging you FYI in case you want to review the Diva upgrade approach, but no obligation!