Fixes some minor repo inconsistencies #3
Conversation
…one inside zenroom.js
Replace eslint-config-airbnb-base with eslint-config-standard, and start using eslint in lint script.
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 66 66
=====================================
Hits 66 66Continue to review full report at Codecov.
|
puria
left a comment
puria
left a comment
There was a problem hiding this comment.
Is the .wasm .mem changed to the latest @decodeproject/zenroom commit? I use to have the last published version of the npm, but fine to have it updated and sync to the actual wrapper code... thanks ;)
| * // returns zenroom | ||
| * import zenroom from 'zenroom' | ||
| * // or without ES6 syntax | ||
| * // const zenroom = require('zenroom').default |
There was a problem hiding this comment.
can you please update also the README.md?
There was a problem hiding this comment.
The .wasm and .js files are the output from Zenroom @ 34cc00c, the commit referred from the submodule, and emscripten
Actually, compiling from the master branch of Zenroom, the wasm produced won't pass the tests in which the script contains a reference to the global ECDH and spits out these messages:
[string "..."]:2: attempt to index a nil value (global 'ECDH')
[string "ZEN:begin(1)..."]:1: attempt to index a nil value (global 'ZEN')[!]
I'd ask @jaromil to give me a hint on how to address this problem
puria
left a comment
puria
left a comment
There was a problem hiding this comment.
uuuuuuh I love standard actually... it hurts you? Or there is a rationale?
4 participants
❤️