feat: SUI-1671 - improve e2e test reliability immediately after deployment#567
Merged
robshakespeare merged 9 commits intomainfrom Apr 16, 2026
Merged
feat: SUI-1671 - improve e2e test reliability immediately after deployment#567robshakespeare merged 9 commits intomainfrom
robshakespeare merged 9 commits intomainfrom
Conversation
…yment Updates the e2e tests to wait for the new version to be started, before they commence. Rather than wait for an arbitrary period of time (which could wait for too long unnecessarily), it waits until the API responds with the expected build number.
|
SummarySummary
CoverageSUI.Find.Application - 91.1%
SUI.Find.AuditProcessor - 11.2%
SUI.Find.Domain - 89.9%
SUI.Find.FindApi - 68.8%
SUI.Find.Infrastructure - 92%
|
udara-jay
approved these changes
Apr 16, 2026
Collaborator
udara-jay
left a comment
udara-jay
left a comment
There was a problem hiding this comment.
Looks great! thanks for doing this! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the e2e tests to wait for the latest version to be deployed and started before the tests commence. Rather than wait for an arbitrary period of time (which could wait for too long unnecessarily), it waits until the API responds with a build timestamp which is on or after a known point in time that confirms the latest version is in use.
Context and background info:
The e2e tests falsely fail when they are automatically ran after deployment. They fail because the e2e tests run immediately after deployment, at which point the deployed API reports that is is up and healthy because the new deployment hasn’t started up yet. Once the function app restarts, the API then temporarily times-out. After a non-determinate period of time, the new version of the API is up and healthy. The changes in this PR ensure that the e2e tests wait for the new version to be deployed and up and running.