Bug removal in resolve#3
Open
letmejustputthishere wants to merge 1 commit intoDFINITY-Education:mainfrom
Open
Conversation
As `parseDomain` pushes the domain from left to right onto the list, we would end up with this list for the domain `subdomain.dfinity.com` (if it would have been implemented correctly, the way it's implemented now the `com` is missing):
HEAD
+
|
|
+---------+ +---------+ +--------+ +----v---+
| null +--->subdomain+-->dfinity +--->com |
| | | | | | | |
+---------+ +---------+ +--------+ +--------+
In the previous code with `List.last` we would assign `?subdomain` to `subdomain` inside the first iteration of the while-loop. We would then ask Root-`server` for `subdomain`. Instead we should ask root for `com` which is the head of the list.
Additionally we would have then called `List.drop<Text>(parsedDomain, counter)` which would have dropped the first 2 elements in our list, leaving us with nothing but
HEAD
+
|
|
v
+---------+ +---+-----+
| null +--->subdomain|
| | | |
+---------+ +---------+
The proposed changes should fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
parseDomainpushes the domain from left to right onto the list, we would end up with this list for the domainsubdomain.dfinity.com(if it would have been implemented correctly, the way it's implemented now thecomis missing):In the previous code with
List.last<Text>(parsedDomain)we would assign?subdomaintosubdomaininside the first iteration of the while-loop. We would then ask Root-serverforsubdomain. Instead we should ask root forcomwhich is the head of the list.Additionally we would have then called
List.drop<Text>(parsedDomain, counter)which would have dropped the first 2 elements in our list, leaving us with nothing butThe proposed changes should fix this.