Skip to content

Conversation

@Shasan634
Copy link
Contributor

@Shasan634 Shasan634 commented Nov 28, 2025

Background

Updated the help button style from text-based "Help" labels to a question mark (?) icon, creating a cleaner UI with better space utilization and improved user experience. The help icon now appears directly beside field labels in the ComboBox component.

Anything in particular that should be highlighted?

Since Linear Threshold doesn't use the ComboBox component, custom styling was applied to ensure its help button and modal maintain the same visual consistency as the ComboBox implementation.

Screenshot(s)

Checks

  • I ran unit tests.
  • I've tested the relevant changes from a user POV.
  • I've formatted my Python code using black ..

Hint To run all python unit tests run the following command from the root repository directory:

bash run_python_tests.sh

@Shasan634 Shasan634 self-assigned this Nov 28, 2025
@Shasan634 Shasan634 added Javascript Code Quality Anything related to the quality of the code css labels Nov 30, 2025
@JustinElms
Copy link
Contributor

Looks great! One small suggestion: the added div adds a lot of padding between the title and the dropdown. Can you modify this so that the spacing is consistent with the previous version of these controls and other dropdowns that do not have a help option?
image
instead of
image

@JustinElms JustinElms merged commit 6a8d0e5 into master Dec 4, 2025
4 checks passed
@JustinElms JustinElms deleted the Help_Button_Style_changed branch December 4, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Quality Anything related to the quality of the code css Javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants