Skip to content

Comments

Other: Run pre-commit only on staged changes#2182

Open
Davknapp wants to merge 28 commits intomainfrom
update-pre-commit
Open

Other: Run pre-commit only on staged changes#2182
Davknapp wants to merge 28 commits intomainfrom
update-pre-commit

Conversation

@Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Feb 13, 2026

Closes #1466

Updates the pre-commit script to do the following:

  • Check the size of the git stash
  • run git stash to stash un-commited changes
  • Check the size again to see if sth has actually been stashed
  • If so print a warning message
  • Run the pre-commit script as usually
  • if something has been stash, pop the stash.

############### QUESTION #################
Should we also include untracked files to the stash?

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

Should prevent the following scenario:
pre-commit fails and the dev does some changes
Changes are not commited
pre-commit runs again, but successfull
Non-updated commit gets push, CI fails

With this update the pre-commit will fail again, because the un-commited changes are stashed
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.97%. Comparing base (322342b) to head (a993b06).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2182   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files         113      113           
  Lines       19106    19106           
=======================================
  Hits        14898    14898           
  Misses       4208     4208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandro-elsweijer
Copy link
Member

I don't know when exactly the pre-commit is performed. If it is really before the commit, this will also stash the added changes which this script should control

@sandro-elsweijer
Copy link
Member

About the question: If they are not added then yes :)

@sandro-elsweijer
Copy link
Member

I don't know when exactly the pre-commit is performed. If it is really before the commit, this will also stash the added changes which this script should control

Nvm, I did not know about the --keep-index option

@Davknapp
Copy link
Collaborator Author

I don't know when exactly the pre-commit is performed. If it is really before the commit, this will also stash the added changes which this script should control

The pre-commit is performed when you execute "git commit", befor the commit is created. It sits between "git add" and "git commit".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use actual committed changes for pre-commit script

2 participants