Improvement: Element data for mesh handle is now defined via mesh competence#2184
Open
lenaploetzke wants to merge 7 commits intohandle_add-partition-and-balancefrom
Open
Improvement: Element data for mesh handle is now defined via mesh competence#2184lenaploetzke wants to merge 7 commits intohandle_add-partition-and-balancefrom
lenaploetzke wants to merge 7 commits intohandle_add-partition-and-balancefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## handle_add-partition-and-balance #2184 +/- ##
====================================================================
+ Coverage 78.46% 78.47% +0.01%
====================================================================
Files 115 116 +1
Lines 19133 19144 +11
====================================================================
+ Hits 15013 15024 +11
Misses 4120 4120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2185
Describe your changes here:
mesh handle: Having element data is now optional via a mesh competence. This makes it easier to define additional mesh competences, e.g. needed for #2115. Moreover, the code is cleaner as the element related functions are outsources in an other file. We do not need the requires clauses if the ElementData is void anymore.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).