Allow Responder Integrator to specify additional opaque data#3485
Allow Responder Integrator to specify additional opaque data#3485
Conversation
|
@steven-bellock would you please review? |
| * opaque_data buffer. | ||
| * | ||
| * @retval true OpaqueData field is generated successfully. | ||
| * If return true, responder will not generate any opaque data, |
There was a problem hiding this comment.
If the Integrator provides the opaque data then they must also set the secured_message_version in the session_info, correct?
There was a problem hiding this comment.
Yes, that is correct.
There was a problem hiding this comment.
libspdm_set_data currently does not support LIBSPDM_DATA_SESSION_SECURED_MESSAGE_VERSION, so that would need to be expanded.
There was a problem hiding this comment.
I think this is not required, because we can rely on libspdm to parse the integrator generated responder opaque data and get the final secured message version.
Otherwise, it is a chicken-egg problem. Session info must be generated AFTER secured message version, while you want set secured message version for a session.
Li-Aaron
force-pushed
the
fix-3401
branch
4 times, most recently
from
1b4cccd to
f4a8716
Compare
|
|
||
| #if (LIBSPDM_ENABLE_CAPABILITY_KEY_EX_CAP) && (LIBSPDM_ENABLE_CAPABILITY_MUT_AUTH_CAP) | ||
| #if LIBSPDM_ENABLE_CAPABILITY_KEY_EX_CAP | ||
| bool g_generate_key_exchange_opaque_data = false; |
There was a problem hiding this comment.
Both true and false passed emu test.
|
|
||
| uint8_t m_cxl_tsp_current_psk_session_index = 0xFF; | ||
|
|
||
| bool g_generate_psk_exchange_opaque_data = false; |
There was a problem hiding this comment.
Both true and false passed emu test.
jyao1
added
the
4.0
|
@Li-Aaron , please resolve conflict. |
fix DMTF#3401 Signed-off-by: Aaron Li <aaron.li@intel.com>
3 participants
fix #3401